Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add 'distinct' argument to VectorParams #206
To enable sampling without replacement.
Currently, sampling with replacement is hardcoded for vector params.
This is needed to sample unique filter methods which are going to be used in ensemble filters.
@jakob-r Is this possible in paradox already?
Edit: The fix obv only works for tuneXXX methods that use
I don't know if we want to to really deal with that here. It will introduce more problems:
As we already discussed we can transform a logical vector param to a distinct factor vector. Also is this just a restriction which you could also include in the
I vote for:
Quoted from above:
"Currently, sampling with replacement is hardcoded for vector params.
Addition: If you create a "DistinctVectorParam" with let's say 15 values and set
Should I open an issue in paradox?
let me try to summarize here already:
a) the current PH implementation allows only for uniform sampling. you now kinda change that, just for a special case.
b) IMHO we are looking at a design problem. params should not implement their sampler. they should simply descibe params. the sampler should be a separate service class. then this can be specialized