Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShortOrange play/pause (fixes #325) and add art #369

merged 1 commit into from Oct 18, 2017


None yet
2 participants
Copy link

bsinky commented Oct 2, 2017

Fix for the Play/Pause selectors for ShortOrange, fixes issue #325. Favored > in selectors for (slightly) better performance at the cost of possibly greater fragility should the hierarchy of those elements change.

Also added art selector.


This comment has been minimized.

Copy link
Contributor Author

bsinky commented Oct 3, 2017

Hm, I've now noticed that commit 9b8b432 (already merged) made some changes to ShortOrangeController, but it hadn't been working for me until my changes in this PR. 🤷‍♂️

If nothing else, my PR can add art for ShortOrange.

@berrberr berrberr merged commit cc5cc24 into berrberr:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@bsinky bsinky deleted the bsinky:fix-shortorange-playpause branch Oct 18, 2017

robled pushed a commit to robled/streamkeys that referenced this pull request Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.