New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current time and total time selectors, implement for several sites #460

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@bsinky
Copy link
Contributor

bsinky commented Oct 7, 2018

This PR adds selectors to pull the time in the current song, and the duration of the current song, and adds this information to the notification popup like so:

image

This implements part of the features outlined in #455.

Also updated the notification popup to exclude lines if they would be empty. For example, since PlexController pulls only song data, not album/artist or time, it displays like so:

image

@berrberr berrberr added this to the 1.7.8 milestone Oct 15, 2018

@berrberr berrberr merged commit 0f01448 into berrberr:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berrberr

This comment has been minimized.

Copy link
Owner

berrberr commented Oct 15, 2018

This is really cool!! Nice idea. I reviewed and code looks good.

Thanks @bsinky !

robled pushed a commit to robled/streamkeys that referenced this pull request Nov 20, 2018

Merge pull request berrberr#460 from bsinky/time-selectors
Add current time and total time selectors, implement for several sites

@bsinky bsinky deleted the bsinky:time-selectors branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment