feat: rework tinder #3139

gfanton · 2021-03-08T10:04:59Z

Rework tinder driver:

Use event bus to advertise on listeners update
Rework multi-driver logic
use github.com/libp2p/go-libp2p-discovery backoff discovery to cache peers on discoverSigned-off-by: Guilhem Fanton guilhem.fanton@gmail.com

codecov · 2021-03-31T15:33:54Z

Codecov Report

Merging #3139 (ec969a7) into master (b1e6996) will increase coverage by 0.58%.
The diff coverage is 61.20%.

@@            Coverage Diff             @@
##           master    #3139      +/-   ##
==========================================
+ Coverage   29.15%   29.74%   +0.58%     
==========================================
  Files         352      352              
  Lines       21939    22026      +87     
  Branches     1685     1685              
==========================================
+ Hits         6396     6551     +155     
+ Misses      14389    14311      -78     
- Partials     1154     1164      +10

Flag	Coverage Δ
go.unittests	`37.75% <61.20%> (+0.79%)`	⬆️
js.unittests	`10.99% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
go/cmd/berty/mini/view_group_incoming.go	`0.00% <0.00%> (ø)`
go/internal/ipfsutil/pubsub_monitor.go	`0.00% <0.00%> (ø)`
go/internal/ipfsutil/testing.go	`0.00% <0.00%> (ø)`
go/internal/lifecycle/manager.go	`0.00% <0.00%> (ø)`
go/internal/tinder/discovery_monitor.go	`0.00% <0.00%> (ø)`
go/internal/tinder/driver_localdiscovery.go	`0.00% <ø> (ø)`
go/internal/tinder/driver_rdv.go	`0.00% <ø> (ø)`
go/internal/tinder/filter.go	`0.00% <0.00%> (ø)`
go/pkg/bertyprotocol/api_group.go	`14.84% <0.00%> (-0.99%)`	⬇️
...components/chat/message/MessageMonitorMetadata.tsx	`5.88% <ø> (+0.32%)`	⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e6996...ec969a7. Read the comment docs.

moul · 2021-04-23T16:59:33Z

go/internal/initutil/ipfs.go

+	fs.DurationVar(&m.Node.Protocol.MinBackoff, "p2p.min-backoff", time.Minute, "minimum p2p backoff duration")
+	fs.DurationVar(&m.Node.Protocol.MaxBackoff, "p2p.max-backoff", time.Minute*10, "maximum p2p backoff duration")


previous setting was 1s, 1m; now we have 1m, 10m

why are you switching to these new values?

I'm much more confident in tinder backoff than before, so I've just increased this to a more reasonable range

aeddi

LGTM 👍

aeddi · 2021-04-26T12:43:22Z

go/internal/initutil/ipfs.go

@@ -60,8 +61,11 @@ func (m *Manager) SetupLocalIPFSFlags(fs *flag.FlagSet) {
 	fs.StringVar(&m.Node.Protocol.Announce, "p2p.swarm-announce", "", "IPFS announce addrs")
 	fs.StringVar(&m.Node.Protocol.NoAnnounce, "p2p.swarm-no-announce", "", "IPFS exclude announce addrs")
 	fs.BoolVar(&m.Node.Protocol.LocalDiscovery, "p2p.local-discovery", true, "if true local discovery will be enabled")


This should be renamed p2p.mdns and a flag p2p.tinder-local-driver should be added (or tinder-local-driver should be removed if it is useless as we discussed earlier).

I will do this in a separate PR

Signed-off-by: Guilhem Fanton <guilhem.fanton@gmail.com>

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

Signed-off-by: gfanton <guilhem.fanton@gmail.com>

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

github-actions · 2021-04-29T11:18:56Z

🎉 This PR is included in version 2.277.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

auto-add-label bot added the WIP label Mar 8, 2021

gfanton force-pushed the feat/tinder-rework branch 6 times, most recently from 24bf878 to b511367 Compare March 15, 2021 12:38

gfanton self-assigned this Mar 15, 2021

gfanton force-pushed the feat/tinder-rework branch 2 times, most recently from 144d7cd to 1292e4e Compare March 17, 2021 17:44

gfanton force-pushed the feat/tinder-rework branch 2 times, most recently from c48a0f6 to c406d6f Compare March 26, 2021 14:52

gfanton force-pushed the feat/tinder-rework branch 2 times, most recently from 1c3b767 to 0a2bbfb Compare April 12, 2021 18:43

moul-bot force-pushed the feat/tinder-rework branch from 994e601 to e3954cc Compare April 15, 2021 14:55

gfanton force-pushed the feat/tinder-rework branch 4 times, most recently from 9b288ec to a7f2d67 Compare April 22, 2021 10:09

gfanton marked this pull request as ready for review April 22, 2021 13:00

gfanton requested review from moul and a team as code owners April 22, 2021 13:00

gfanton force-pushed the feat/tinder-rework branch from 56c8a24 to 6ba0b02 Compare April 23, 2021 15:27

gfanton changed the title ~~wip: rework tinder~~ feat: rework tinder Apr 23, 2021

auto-add-label bot added the enhancement label Apr 23, 2021

moul reviewed Apr 23, 2021

View reviewed changes

aeddi approved these changes Apr 26, 2021

View reviewed changes

gfanton force-pushed the feat/tinder-rework branch from 0f3785c to 4eec812 Compare April 28, 2021 16:34

gfanton and others added 21 commits April 29, 2021 10:58

feat: rework tinder

6d2667b

Signed-off-by: Guilhem Fanton <guilhem.fanton@gmail.com>

chore: move pubsub trim into api group

bb4e2db

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

feat: add tinder service test

5f6e542

Signed-off-by: gfanton <guilhem.fanton@gmail.com>

chore: cleanup

715269e

Signed-off-by: gfanton <guilhem.fanton@gmail.com>

feat: enable back directchannel

f3e5098

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

feat: add ipfs config

6ff8b32

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: update config generator

3d9d27e

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

feat: use static relays

e2f2f7b

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: tinder service test

1b9804a

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: tinder leak context

7aa5d82

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: split tinder service

da1c916

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: cleanup tinder

787d39d

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

feat: add tinder opts

226a8e9

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: lint

12103f7

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: fix blackbox test

2c0ab63

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: test

8c7ae1b

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: disable find_peers/100_drivers test

33331a3

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore tmp disable filter private addrs on rdvp

f9237d6

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: disable tests where maximum goroutines were reached

7980edf

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: windows test

ed8302c

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: cleanup log/comments

ec969a7

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton force-pushed the feat/tinder-rework branch from 4eec812 to ec969a7 Compare April 29, 2021 09:01

gfanton merged commit 0f0d04f into berty:master Apr 29, 2021

gfanton deleted the feat/tinder-rework branch April 29, 2021 11:17

github-actions bot added the released label Apr 29, 2021

aeddi added 🚧 WIP and removed WIP labels Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rework tinder #3139

feat: rework tinder #3139

gfanton commented Mar 8, 2021 •

edited by moul-bot

codecov bot commented Mar 31, 2021 •

edited

moul Apr 23, 2021

gfanton Apr 29, 2021

aeddi left a comment

aeddi Apr 26, 2021

gfanton Apr 29, 2021

github-actions bot commented Apr 29, 2021

		fs.DurationVar(&m.Node.Protocol.MinBackoff, "p2p.min-backoff", time.Minute, "minimum p2p backoff duration")
		fs.DurationVar(&m.Node.Protocol.MaxBackoff, "p2p.max-backoff", time.Minute*10, "maximum p2p backoff duration")

feat: rework tinder #3139

feat: rework tinder #3139

Conversation

gfanton commented Mar 8, 2021 • edited by moul-bot

codecov bot commented Mar 31, 2021 • edited

Codecov Report

moul Apr 23, 2021

Choose a reason for hiding this comment

gfanton Apr 29, 2021

Choose a reason for hiding this comment

aeddi left a comment

Choose a reason for hiding this comment

aeddi Apr 26, 2021

Choose a reason for hiding this comment

gfanton Apr 29, 2021

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2021

gfanton commented Mar 8, 2021 •

edited by moul-bot

codecov bot commented Mar 31, 2021 •

edited