fix: remove InsecureSkipVerify #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
+ Coverage 29.84% 29.85% +0.01%
==========================================
Files 372 372
Lines 32628 32622 -6
Branches 1740 1740
==========================================
+ Hits 9738 9740 +2
+ Misses 21619 21611 -8
Partials 1271 1271
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/full-service-tls
branch
from
40bd6fa
to
50aa6ba
Compare
n0izn0iz
reviewed
Nov 8, 2021
| @@ -53,6 +54,10 @@ func TestNewService(t *testing.T) { | |||
| func TestAdvertiseWatchdogs(t *testing.T) { | |||
| const advertisekey = "test_key" | |||
|
|
|||
| if runtime.GOOS == "windows" { | |||
| t.Skip("this test fail sometimes on windows for unknown reason") | |||
There was a problem hiding this comment.
maybe only mark it unstable on windows ?
There was a problem hiding this comment.
There is no unstable test for windows
|
🎉 This PR is included in version 2.318.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
InsecureSkipVerifyopt on grpc service