New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove InsecureSkipVerify #3646
Conversation
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov Report
@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
+ Coverage 29.84% 29.85% +0.01%
==========================================
Files 372 372
Lines 32628 32622 -6
Branches 1740 1740
==========================================
+ Hits 9738 9740 +2
+ Misses 21619 21611 -8
Partials 1271 1271
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
40bd6fa
to
50aa6ba
Compare
@@ -53,6 +54,10 @@ func TestNewService(t *testing.T) { | |||
func TestAdvertiseWatchdogs(t *testing.T) { | |||
const advertisekey = "test_key" | |||
|
|||
if runtime.GOOS == "windows" { | |||
t.Skip("this test fail sometimes on windows for unknown reason") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe only mark it unstable on windows ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no unstable test for windows
🎉 This PR is included in version 2.318.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
remove
InsecureSkipVerify
opt on grpc service