Skip to content

Use encodeURI instead of escapeHTML since the src is url #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bertybot merged 2 commits into from
Mar 17, 2025
Merged

Use encodeURI instead of escapeHTML since the src is url #14

bertybot merged 2 commits into from
Mar 17, 2025

Conversation

@jando-ashley
Copy link
Contributor

@jando-ashley jando-ashley commented Mar 17, 2025

Issue: When url prop contains ampersand, escapeHTML encodes it to & and pass it to src of iFrame. It caused the URL to not work properly.

Fix: Replaced escapeHTML() with encodeURI()

@bertybot
Copy link
Owner

bertybot commented Mar 17, 2025

Change set

@jando-ashley
Copy link
Contributor Author

jando-ashley commented Mar 17, 2025

Added changeset!

@bertybot bertybot self-assigned this Mar 17, 2025
@bertybot bertybot merged commit 85ccc1c into bertybot:master Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertybot bertybot bertybot approved these changes

Assignees

@bertybot bertybot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jando-ashley @bertybot