Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Some additions #1

Closed
wants to merge 9 commits into from

2 participants

@trapd00r

Hi Ivan,

See the commit messages for descriptions.

trapd00r added some commits
@trapd00r trapd00r allow for other countries to be specified
Replaced conditional and use with require and ""->can
b28aaa5
@trapd00r trapd00r remove the usage of warnings
It's a module - we should either fail as soon as possible as loud as possible or
be quiet.
fc99228
@trapd00r trapd00r samle.pl: rewrite
Show how to use different target countries.
Use lib.pm so the script can be run without installing the whole package.
df718bc
@trapd00r trapd00r add tests for SV.pm 4235c4b
@trapd00r trapd00r 002_generate_person.t: fix typo 0192dd7
@trapd00r trapd00r add Mock::Person::SV 4c2e839
@trapd00r trapd00r fix typo in sample.pl filename and move it to examples/ baac96e
@trapd00r trapd00r update MANIFEST 9591737
@trapd00r trapd00r Makefile.PL: bump version number to 0.02 7827d28
@bessarabov
Owner

Thank you for the great work!

I agree with you that module should die as soon as possible, but I don't want to remove warnings. I'm thinking about replacing warnings with dying (as described here http://www.effectiveperlprogramming.com/blog/310).

I'm not sure that Mock::Person::SV should be part of this module. You have already published in on CPAN, so I think It is better be published under your name so you will maintain it in your own repo https://github.com/trapd00r/Mock-Person-SV

So I'm planning to do 2 things with your code: 1) remove Mock::Person::SV 2) die on any warnings. What do you think?

@trapd00r

Yeah, I wasn't sure if you wanted to distribute other languages with it; I do think, however, that it'd be better to have an english wordlist as the default one. Or alternatively, not include any wordlist at all in Mock::Person, and have subclasses for each language. It's a bit weird having the russian one included with the dist and nothing more. :)

But I'm fine with whatever you prefer.

@bessarabov
Owner

You did a great work for the Mock::Person module. Sorry for not merging this PR. And sorry, I was mistaken that we should split this into several CPAN distributions. I'm closing this PR without merge, because I'm doing the big change of the module and the things that you propose here are done in the git branch big_change. The discussion of this change is at #7

@bessarabov bessarabov closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 3, 2011
  1. @trapd00r

    allow for other countries to be specified

    trapd00r authored
    Replaced conditional and use with require and ""->can
  2. @trapd00r

    remove the usage of warnings

    trapd00r authored
    It's a module - we should either fail as soon as possible as loud as possible or
    be quiet.
  3. @trapd00r

    samle.pl: rewrite

    trapd00r authored
    Show how to use different target countries.
    Use lib.pm so the script can be run without installing the whole package.
  4. @trapd00r

    add tests for SV.pm

    trapd00r authored
  5. @trapd00r
  6. @trapd00r

    add Mock::Person::SV

    trapd00r authored
  7. @trapd00r
  8. @trapd00r

    update MANIFEST

    trapd00r authored
  9. @trapd00r
Something went wrong with that request. Please try again.