New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading when both `define` and `exports` exist #33

Merged
merged 1 commit into from Apr 26, 2013

Conversation

4 participants
@ansis
Contributor

ansis commented Apr 24, 2013

We ran into problems when users tried to use mapbox.js, which uses browserify, on a site with requirejs. Since define was defined, nothing was added to exports.

With this change, if both define and exports are present it will load it with both systems.

@kitcambridge

This comment has been minimized.

Show comment
Hide comment
@kitcambridge

kitcambridge Apr 26, 2013

Member

I think that's a reasonable change—JSON 3 has had an interesting history with module exports (see #26 and #14), but this looks solid. Thank you!

Member

kitcambridge commented Apr 26, 2013

I think that's a reasonable change—JSON 3 has had an interesting history with module exports (see #26 and #14), but this looks solid. Thank you!

@kitcambridge kitcambridge merged commit b88d4af into bestiejs:v3.2.5 Apr 26, 2013

@bnjmnt4n bnjmnt4n added the enhancement label Oct 9, 2014

@calhoun137

This comment has been minimized.

Show comment
Hide comment
@calhoun137

calhoun137 Aug 5, 2015

Thank you so much for this PR!!!!!! It solved a 3 day nightmare <3

calhoun137 commented Aug 5, 2015

Thank you so much for this PR!!!!!! It solved a 3 day nightmare <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment