Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zh update again #39

Merged
merged 3 commits into from Feb 3, 2019
Merged

Zh update again #39

merged 3 commits into from Feb 3, 2019

Conversation

@seognil
Copy link
Contributor

seognil commented Feb 1, 2019

clearer now
three commit from my new branch from the latest dev branch

  • first the Chinese update
  • second other things such as arch-rival staff && yarn in readme

  • the latest commit is just my personal favor
    I made some sorting job on existed teamMember data (by time and language)
    // changed some code 馃槄
seognil added 3 commits Feb 1, 2019
@michaelrambeau michaelrambeau merged commit 0b19a9b into bestofjs:dev Feb 3, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@michaelrambeau

This comment has been minimized.

Copy link
Member

michaelrambeau commented Feb 3, 2019

Thank you @seognil I've merged the code into the master branch.

I changed the order of the "Team members" in the README.md, they are now sorted by first name.

@seognil seognil deleted the seognil-contributor:zh-update branch Feb 4, 2019
@seognil seognil restored the seognil-contributor:zh-update branch Feb 4, 2019
@seognil seognil deleted the seognil-contributor:zh-update branch Feb 4, 2019
@seognil

This comment has been minimized.

Copy link
Contributor Author

seognil commented Feb 4, 2019

@michaelrambeau yeah great, a better way
thanks too for the acception :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.