Skip to content

Allow for limiting tables to a db schema during field introspection #3

Open
wants to merge 2 commits into from

2 participants

@jasonmay
jasonmay commented Apr 5, 2012

If the user intends to use DBIx::SB for only a specific schema, this can
save some time on the initial field population process.

@jasonmay jasonmay Allow for limiting tables to a db schema during field introspection
If the user intends to use DBIx::SB for only a specific schema, this can
save some time on the initial field population process.
3b80496
@tsibley
tsibley commented Apr 5, 2012

Can you write tests for this?

@jasonmay
jasonmay commented Apr 5, 2012

Sure. Any guidance as to where and how I should approach it? Thanks.

@tsibley
tsibley commented Apr 5, 2012

I assume you ran into a failure case related to either external use of ->HasField / ->Fields or an internal bug in SB's DistinctQuery handling on Pg when column_info wasn't limited to a schema. A test case would show why it's useful (i.e. an example circumstance where it matters) and that it actually works.

@jasonmay
jasonmay commented Apr 5, 2012

The issue we ran into was speed-related only, so I can't really write a failing test. However, I'll write a test to ensure the change doesn't affect anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.