Browse files

fix the callback arg passing; try to fix some uninitialized string wa…

…rnings
  • Loading branch information...
1 parent 3144ae9 commit 9367ccfb12d18348b31f7370a2ca327f997e6007 @tla tla committed Aug 7, 2007
View
1 MANIFEST
@@ -1,5 +1,4 @@
Changes
-html/Callbacks/ActivityReports/Elements/Header/1
html/Callbacks/ActivityReports/Elements/Header/Head
html/Callbacks/ActivityReports/Elements/Tabs/Default
html/Callbacks/ActivityReports/NoAuth/webrt.css/Default
View
10 html/Reports/Activity/Elements/LimitReport
@@ -5,23 +5,23 @@ Query:
Report type: <select name="ReportType">
<option value="ActivityDetail" <% $ReportType =~ /ActivityDetail/ ? 'selected' : '' %>>Activity detail</option>
<option value="ActivitySummary" <% $ReportType =~ /ActivitySummary/ ? 'selected' : '' %>>Activity summary</option>
-<& /Elements/Callback, _CallbackName => 'AddReports', ARGSref => \%ARGS &>
+<& /Elements/Callback, _CallbackName => 'AddReports', %ARGS &>
<option value="ResolutionComments" <% $ReportType =~ /ResolutionComments/ ? 'selected' : '' %>>Resolution comments</option>
<option value="ResolutionStatistics" <% $ReportType =~ /ResolutionStatistics/ ? 'selected' : '' %>>Resolution statistics</option>
<option value="WorkedStatistics" <% $ReportType =~ /WorkedStatistics/ ? 'selected' : '' %>>Time worked statistics</option>
</select><br />
Start date: <input type="text" name="Start" value="<% $Start %>" /><br />
End date: <input type="text" name="End" value="<% $End %>" /><br />
-Limit to user: <& /Elements/SelectOwner, Name => "Actor", ValueAttribute => 'Name', Default => $Actor &>
-<& /Elements/Callback, _CallbackName => 'AddOptions', ARGSref => \%ARGS &>
+Limit to user: <& /Elements/SelectOwner, Name => "Actor", ValueAttribute => 'Name' &>
+<& /Elements/Callback, _CallbackName => 'AddOptions', %ARGS &>
<& /Elements/Submit, Label => loc('Report') &>
</form>
<%args>
-$ReportType => undef
+$ReportType => ''
$Start => undef
$End => undef
-$Query => undef
+$Query => ''
$Actor => undef
</%args>
<%init>
View
2 html/Reports/Activity/Elements/PrintHeader
@@ -1,7 +1,7 @@
<%args>
$title => undef
$path => undef
-$Query => undef
+$Query => ''
</%args>
<HTML>
<HEAD>
View
4 html/Reports/Activity/index.html
@@ -11,7 +11,7 @@
</&>
<%args>
-$ReportType => undef
+$ReportType => ''
$mode => 'screen'
</%args>
<%init>
@@ -35,7 +35,7 @@
$ARGS{show_print_link} = 0 unless $ReportType;
-$m->comp( '/Elements/Callback', _CallbackName => 'FlipInvoiced', ARGSref => \%ARGS );
+$m->comp( '/Elements/Callback', _CallbackName => 'FlipInvoiced', %ARGS );
my $saved_search = $m->comp( '/Widgets/SavedSearch:new',
SearchType => 'ActivityReport',
View
4 html/Search/ActivityReport.html
@@ -1,8 +1,8 @@
<%args>
-$ReportType => undef
+$ReportType => ''
$Start => undef
$End => undef
-$Query => undef
+$Query => ''
</%args>
<%init>
$m->redirect('/Reports/Activity/index.html?' . $m->comp('/Elements/QueryString', Query => $Query, Start => $Start, End => $End, ReportType => $ReportType));
View
4 html/Search/Elements/ActivityReport
@@ -1,8 +1,8 @@
<%args>
-$ReportType => undef
+$ReportType => ''
$Start => undef
$End => undef
-$Query => undef
+$Query => ''
$Actor => undef
</%args>
<& '/Reports/Activity/Elements/'.$ReportType, start => $Start, end => $End, query => $Query, actor => $Actor &>

0 comments on commit 9367ccf

Please sign in to comment.