Skip to content
Commits on Dec 18, 2014
  1. @alexmv

    Version 1.02 releng

    alexmv committed Dec 18, 2014
  2. @alexmv

    Packaging updates

    alexmv committed Dec 18, 2014
  3. @alexmv
  4. @alexmv

    Move Shredder out of DESCRIPTION

    alexmv committed Dec 18, 2014
  5. @alexmv
  6. @alexmv

    Remove the one piece of developer POD

    alexmv committed Dec 18, 2014
    Its position in the POD implies that "Next" is a UTILITY
Commits on Dec 1, 2014
  1. @alexmv

    Version 1.01 releng

    alexmv committed Dec 1, 2014
  2. @alexmv

    Fix name of upgrading script

    alexmv committed Dec 1, 2014
    Fixes rt.cpan.org #100635
Commits on Jun 20, 2014
  1. @alexmv

    Version 0.13 releng

    alexmv committed Jun 20, 2014
Commits on Jun 19, 2014
  1. @alexmv
Commits on Mar 27, 2014
  1. @alexmv

    Version 0.12 releng

    alexmv committed Mar 27, 2014
Commits on Feb 10, 2014
  1. @alexmv

    Bump version to 12_03

    alexmv committed Feb 10, 2014
  2. @alexmv

    Clean up whitespace

    alexmv committed Feb 10, 2014
  3. @alexmv

    Keep the Disabled bit synchronized between merged users

    alexmv committed Feb 10, 2014
    Disabling a user did not disable all of the users merged into them.
    This caused users disabled users to apparently still appear via the web
    UI in user searches, as their merged-in (non-disabled) users often still
    matched the search.
    
    Explicitly propagate Disabled updates on users down into their merged-in
    equivalents.  Note that changes to sub-users do not propagate upward;
    loading them takes explicit effort, changing them could be more
    surpising action-at-a-distance, and introduces difficulties with dealing
    with cycles.
Commits on Feb 6, 2014
  1. @alexmv

    Bump version to 12_03

    alexmv committed Feb 6, 2014
  2. @alexmv

    Reformat Changes

    alexmv committed Feb 6, 2014
  3. @alexmv

    ->CanonicalizeEmailAddress may be a class method; don't assume $self

    alexmv committed Feb 6, 2014
    0357340 switched several uses of $RT::SystemUser to $self->CurrentUser,
    on the basis that the current user should be propagated throughout,
    rather than fixed to the current user.  However, the change in
    CanonicalizeEmailAddress was overzealous, as that can be called as a
    class method.
    
    As the $canonical_user in this context is lexical, is not altered, and
    should not be ACL'd in any way, hardcoding the system user is correct;
    restore it.
Commits on Jan 27, 2014
  1. @alexmv
Commits on Jan 9, 2014
  1. @alexmv

    Avoid forcing the user to the current user

    alexmv committed Jan 8, 2014
    This allows the Creator of the EffectiveId to serve as a signal as to who merged the users
Commits on Sep 24, 2013
  1. @alexmv

    Update inc/

    alexmv committed Sep 24, 2013
Commits on Jul 17, 2013
  1. @alexmv

    Bump Module::Install::RTx version

    alexmv committed Jul 17, 2013
  2. @alexmv
Commits on Jun 26, 2013
  1. @alexmv

    Version 0.09 releng

    alexmv committed Jun 26, 2013
Commits on Jun 10, 2013
  1. @alexmv

    Ensure that ->Count on a fetched collection returns the same number o…

    alexmv committed Jun 10, 2013
    …f items ->Next will see
  2. @alexmv

    Ensure that ->GotoFirstItem clears the list of "seen" items

    alexmv committed Jun 10, 2013
    Failure to do so would cause the following to fail:
        my $id = $users->First->id;
        $users->GotoFirstItem;
        is( $id, $users->First->id );
    
    ...as the firt user would have been marked "already seen" and thus would
    be ignored on successive iterations through the collection.
Commits on Mar 25, 2013
  1. @alexmv

    Fix "Merge User" box during user creation

    alexmv committed Mar 25, 2013
    c7467a9 missed the one case in which users do not have an attribute --
    namely, when the user object does not exist yet.  During user creation,
    do not present the "Merge User" box at all, as merging would not work.
Commits on Mar 22, 2013
  1. @alexmv
  2. @alexmv
Commits on Mar 12, 2013
  1. @alexmv

    Remove Hook::LexWrap, and replace with a simpler glob manipulation

    alexmv committed Mar 12, 2013
    Hook::LexWrap is unnecessary: the wrapping being done was not lexical,
    and it was not being used for its abilities to alter return or argument
    values.  Remove it, as using it anywhere causes _all_ stack traces to
    lack argument values at all levels of the stacktrace.
Commits on Feb 27, 2013
  1. @alexmv

    Ensure that $canonical_self, when inspected, still has unmerged data

    alexmv committed Feb 27, 2013
    $canonical_self->SetComments() calls a $self->Load( $self->id ) during
    the process of updating the Comments.  Because this now loads the data
    of the user we are merged into, the information recorded on $merged was
    always contentless -- namely, it always showed the the user had been
    merged into itself.
    
    Swap the order of the ->SetComments calls, to ensure that
    $canonical_self is still the user being merged in when it is inspected
    to record data on $merge.
  2. @alexmv

    Explicitly checking EffectiveId is also unneeded in CanonicalizeEmail…

    alexmv committed Feb 27, 2013
    …Address
    
    As CanonicalizeEmailAddress uses ->LoadByCols to look up the email
    address, and we override LoadByCols to chase EffectiveId after a
    successful LoadByCols call, looking up EffectiveId again is unnecessary.
    
    The recursive call is kept, on the possibility that
    CanonicalizeEmailAddressMatch will match the _new_, canonicalized form.
    This preserves the previous behavior.
  3. @alexmv

    Explicitly canonicalizing both $merged and $canonical_self is not req…

    alexmv committed Feb 27, 2013
    …uired
    
    As the path to get both user objects uses ->Load, which calls
    ->LoadByCols, which we have overridden, we already have the most
    canonical form.  Checking it for EffectiveId is unnecessary and
    wasteful.
Commits on Feb 26, 2013
  1. @alexmv
Commits on Feb 25, 2013
  1. @alexmv @tsibley

    Record the merged/mergee's user Name if EmailAddress is empty

    alexmv committed with tsibley Feb 25, 2013
    This avoids uninitialized in concatenation warnings and is more useful
    than a blank in user comments.
Something went wrong with that request. Please try again.