Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Provide an upgrade-database target to ease upgrades

This not only reduces typos by makign the command shorter, it encourages
the command to be run from the source directory.
  • Loading branch information...
commit 248522d0a1d0adf4d85bf7e33ca7f2d74458f2d5 1 parent 34a86f6
@alexmv alexmv authored
Showing with 5 additions and 3 deletions.
  1. +4 −1 Makefile.in
  2. +1 −2  README
View
5 Makefile.in
@@ -254,7 +254,7 @@ upgrade-instruct:
@echo "Congratulations. RT has been upgraded. You should now check over"
@echo "$(CONFIG_FILE) for any necessary site customization. Additionally,"
@echo "you should update RT's system database objects by running "
- @echo " $(RT_SBIN_PATH)/rt-setup-database --prompt-for-dba-password --action upgrade"
+ @echo " make upgrade-database"
upgrade: testdeps config-install dirs files-install fixperms upgrade-instruct
@@ -362,6 +362,9 @@ initdb :: initialize-database
initialize-database:
$(PERL) -I$(LOCAL_LIB_PATH) -I$(RT_LIB_PATH) sbin/rt-setup-database --action init --prompt-for-dba-password
+upgrade-database:
@cloos
cloos added a note

Maybe add upgradedb for consistency as we also have an initdb and dropdb.

upgradedb was a little too close to upgrade for comfort. We've bikeshedded on this a lot and I suspect at this point we're going with upgrade-database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ $(PERL) -I$(LOCAL_LIB_PATH) -I$(RT_LIB_PATH) sbin/rt-setup-database --action upgrade --prompt-for-dba-password
+
dropdb:
$(PERL) -I$(LOCAL_LIB_PATH) -I$(RT_LIB_PATH) sbin/rt-setup-database --action drop --prompt-for-dba-password
View
3  README
@@ -162,8 +162,7 @@ GENERAL INSTALLATION
This will also prompt you to upgrade your database by running:
- /opt/rt4/sbin/rt-setup-database \
- --prompt-for-dba-password --action upgrade
+ make upgrade-database
You should back up your database before running this command.
When you run it, you will be prompted for your previous version of
Please sign in to comment.
Something went wrong with that request. Please try again.