Ticket graph connection finding/handling patch

[atus42]

The original way the ticket links were finded and handled has a flaw. If
a ticket was reached first in a 'longer' path/way than the shortes way
from the root ticket, it got a bigger CurrentDepth as it should be. Later
this ticket were skipped because it was 'already seen' but the
CurrentDepth were not checked.

To handle connections and CurrentDepth correctly, the whole algorithm
should be rewriten from depth-first to child-first search.

[atus42]

attached a before / after screenshot of the same graph.
You can see that ticket #50 has two "DependsOn" entry but one of them didn't drawed. It is because the loop in TicketLinks reach ticket #50 in this way: 40->48->50. The grap's main link type is 'MemberOf'. Because the link between 48 and 50 is DependsOn (not the main type) the links of ticket 50 is not processed. When the loop reaches ticket #50 directly from ticket #40, the ticket #50 is already on the '$args{'Seen'}' list, so it is skipped, so the link between #50 and #46.

[atus42]

Can anyone review and merge this? Please.

[alexmv]

Thanks for the patch; you're right that this should ideally be redesigned from a depth-first to a breadth-first search. Your patch is a fine stopgap -- however, the format commit message needs some minor tweaking. All of the lines should be < 75 characters, and the first line should be as succinct a summary as possible.

[atus42]

Changed the title and the first comment according to the suggestions you made.

[atus42]

Also changed the git commit message.

[alexmv]

I've reworded slightly and merged to 4.2-trunk. Thanks!