Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript error map.js #951

Merged
merged 1 commit into from Feb 27, 2018
Merged

Conversation

McGiverGim
Copy link
Member

Fixes #950

The map.js is loaded in the map.html directly:

<script src="/js/tabs/map.js"></script>

So I think is not needed in the main.html. This seems to fix the issue but:

  • I've not tested if the map is working, my GPS is dead so I can't test it.
  • I don't know if there's other feature that needs the map.js, I haven't found one.

@@ -90,7 +90,6 @@
<script type="text/javascript" src="./js/tabs/adjustments.js"></script>
<script type="text/javascript" src="./js/tabs/servos.js"></script>
<script type="text/javascript" src="./js/tabs/gps.js"></script>
<script type="text/javascript" src="./js/tabs/map.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! I'd only looked in map.html, which seems to be all fine.

@mikeller mikeller added this to the 10.2.0 milestone Feb 27, 2018
@mikeller mikeller merged commit 6455b94 into betaflight:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when loading map
2 participants