Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate DSHOT port configuration #11915

Merged
merged 1 commit into from Oct 25, 2022

Conversation

SteveCEvans
Copy link
Member

@SteveCEvans SteveCEvans commented Oct 22, 2022

Following from #11494 which fixed the GPIO speed initialisation for bitbang DSHOT in src/main/drivers/dshot_bitbang.c there was still initialisation being done in src/main/drivers/dshot_bitbang_ll.c and src/main/drivers/dshot_bitbang_stdperiph.c which this PR removes.

Tested on MATEKF405TE, TMOTORF7 and MAMBAH743.

@SteveCEvans SteveCEvans self-assigned this Oct 22, 2022
@SteveCEvans SteveCEvans added this to the 4.4 milestone Oct 22, 2022
@blckmn
Copy link
Member

blckmn commented Oct 22, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@blckmn blckmn merged commit 6941a11 into betaflight:master Oct 25, 2022
Finalizing Firmware 4.4 Release automation moved this from Firmware to Closed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants