-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix/enhance NMEA & Ublox message polling for GPS #12022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Tested, works, provided Debug=GPS_DOP log on discord, from commit Used "Flywoo GM8 Mini V2.0 GPS Module" at 115200 baud on a F7X2 SkyStars FC. Observed very fast lock, but that could be coincidental. Coordinate map, speed, satellites, altitude, distance from home all look good, meet or exceed previous behavior. |
|
@benjamind2 Thanks for testing! You tested this with the UBlox protocol, so now we need to make sure this also works on the NMEA protocol 👍 Edit: But there is a bug where velocity for GPS Rescue gets now updated by several GPS messages with different values. There is a fix ready for testing. Tomorrow we will know more. |
e521d74 to
3b23ea1
Compare
This comment has been minimized.
This comment has been minimized.
3b23ea1 to
7c0b0b9
Compare
This comment has been minimized.
This comment has been minimized.
7c0b0b9 to
60eac87
Compare
This comment has been minimized.
This comment has been minimized.
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
Sek101 confirmed with logs that it is now fixed |
This PR fixes some bugs/problems on both NMEA and U-blox protocols to make DOP values work properly. In addition I refactored the code to save some flash and added the U-blox accuracy estimate for position to the GPS solution for use in BF.
The commit names describe in detail what I changed.
Thanks a lot to @ctzsnooze for laying the groundwork for this PR and identifying the problems.
Also thanks a lot to the testers: @benjamind2 and Sek101