Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS Rescue fix (rescueYaw needs to be signed) #6193

Merged
merged 2 commits into from Jun 23, 2018

Conversation

Projects
None yet
4 participants
@dbasch
Copy link
Contributor

dbasch commented Jun 22, 2018

Changed from unsigned to signed.

@DieHertz
Copy link
Member

DieHertz left a comment

This looks weird, here's what rcCommand says:
float rcCommand[4]; // interval [1000-2000]

So what is the range of rcCommand items after all?

@DieHertz

This comment has been minimized.

Copy link
Member

DieHertz commented Jun 23, 2018

Overlooked it's [-500; 500] for channels other than throttle.
It looks a bit weird to use anything besides [-1.0, 1.0] for floats of such semantics though.
Something to refactor in the next release.

@DieHertz DieHertz merged commit 4c14952 into betaflight:master Jun 23, 2018

@mikeller mikeller added this to the Betaflight v3.4 milestone Jun 23, 2018

@mikeller mikeller added the RN: BUGFIX label Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.