Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for STM32F765xx #6669

Merged
merged 5 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@DieHertz
Copy link
Member

DieHertz commented Aug 30, 2018

Also adds a KAKUTEF765 variant which is otherwise the same as KAKUTEF7

@@ -22,8 +22,17 @@

//#define USE_TARGET_CONFIG

#ifdef KAKUTEF765

This comment has been minimized.

@mikeller

mikeller Aug 30, 2018

Member

Can we please have this as 2 separate pull request, one for the F765 and one for the new target?

This comment has been minimized.

@DieHertz

DieHertz Aug 30, 2018

Author Member

It quite makes sense to me in having the first ever F765 target added in the same PR as MCU support, but I don't care.

@@ -31,6 +31,7 @@ extern uint8_t __config_start; // configured via linker script when building b
extern uint8_t __config_end;
#endif

// @todo this is not strictly correct for F4/F7, where sector sizes are variable

This comment has been minimized.

@ledvinap

ledvinap Aug 30, 2018

Contributor

(IMO flash page size in area used for config is important. But this value may be inherited from linker script, so config location and page size is together
Also page boundaries may be used to infer correct sector and int size
)

This comment has been minimized.

@DieHertz

DieHertz Aug 30, 2018

Author Member

Okay then it's fine

@@ -131,6 +140,16 @@ static uint32_t getFLASHSectorForEEPROM(void)
return FLASH_SECTOR_6;
if ((uint32_t)&__config_start <= 0x080FFFFF)
return FLASH_SECTOR_7;
#if defined(STM32F765xx)

This comment has been minimized.

@ledvinap

ledvinap Aug 30, 2018

Contributor

(BTW: this can be implemented as array of page boundaries)

This comment has been minimized.

@DieHertz

DieHertz Aug 30, 2018

Author Member

Sure, I leave it for a PR where scatter loading is done uniformly for all platforms, with as little assembly as possible (or none at all).

@DieHertz DieHertz force-pushed the DieHertz:bfdev-f76x-support branch from 3868bad to 144fe59 Sep 3, 2018

@DieHertz DieHertz force-pushed the DieHertz:bfdev-f76x-support branch from 144fe59 to 8073cb8 Sep 7, 2018

@DieHertz DieHertz referenced this pull request Sep 7, 2018

Merged

Added KAKUTEF7V2 target #6706

@DieHertz

This comment has been minimized.

Copy link
Member Author

DieHertz commented Sep 7, 2018

It came to my attention that F76x has new AF options for UARTs, so I refactored uart_pincofig similarly to how it's done for SPI, defining AF per each pin.
F1/F3/F4 only changed cosmetically to accommodate this change.
I will review the datasheets to make sure other peripherals haven't undergone a similar change.

@DieHertz DieHertz changed the title Added preliminary support for STM32F765xx Added support for STM32F765xx Sep 7, 2018

@@ -26,7 +26,7 @@
#pragma GCC poison sprintf snprintf
#endif

#if defined(STM32F745xx) || defined(STM32F746xx) || defined(STM32F722xx)
#if defined(STM32F765xx) || defined(STM32F745xx) || defined(STM32F746xx) || defined(STM32F722xx)

This comment has been minimized.

@mikeller

mikeller Sep 8, 2018

Member

Minor niggle, but should we order these?

This comment has been minimized.

@DieHertz

DieHertz Sep 9, 2018

Author Member

Sure, why not

@mikeller mikeller added this to the 4.0 milestone Sep 8, 2018

@mikeller mikeller merged commit 5ef68ef into betaflight:master Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.