Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'small_angle' indicator to OSD flip arrow. #7250

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
None yet
2 participants
@mikeller
Copy link
Member

mikeller commented Dec 19, 2018

This allows the 'crash flip arrow' to be used as an indicator for a tilted craft as well - the arrow will show when disarmed (only if small_angle isn't set to 180) if the tilt angle is exceeded. When in crash flip mode, the arrow will only show when the tilt angle is exceeded.

Also, cleaned up the calculation to use the proper quadrants, and cleaned up an unnecessary buffer variable in the small angle calculation.

@mikeller mikeller added this to the 4.0 milestone Dec 19, 2018

@etracer65

This comment has been minimized.

Copy link
Member

etracer65 commented Dec 19, 2018

OSD unit test is failing but otherwise good. Tested on OMNIBUSF4SD and works as expected. I'm torn on which way the arrow should point when displayed in normal mode (not crash flip). At the moment it's following the crash flip logic indicating which way to push the stick. Not sure if this is more intuitive or the reverse would be better to indicate which way the quad is leaning. No opportunity to push the stick to level if you can't arm. My first impression was that it seemed backwards and then after thinking about it I understood what was going on.

@mikeller

This comment has been minimized.

Copy link
Member Author

mikeller commented Dec 21, 2018

Yes, it is not intuitive at first glance, but the arrow pointing in the direction to pull the stick to once armed (in crash flip mode as it won't arm otherwise) seems a better option than showing the direction to pull in the theoretical case of arming without crash flip.

@mikeller mikeller merged commit f827c33 into betaflight:master Dec 21, 2018

@mikeller mikeller deleted the mikeller:add_small_angle_to_flip_arrow branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.