Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F3, ESCSERIAL] Conditionalize SimonK handling from escserial and drop it from F3 #7272

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
2 participants
@jflyper
Copy link
Contributor

jflyper commented Dec 23, 2018

Yields 600+ bytes of flash space.

@@ -50,6 +50,7 @@

typedef enum {
BAUDRATE_NORMAL = 19200,
BAUDRATE_SIMONK = 28800, // = 9600 * 3

This comment has been minimized.

@mikeller

mikeller Dec 23, 2018

Member

Is this needed anywhere?

This comment has been minimized.

@jflyper

jflyper Dec 23, 2018

Author Contributor

Oops. It's leaked from the next phase refactor. It corresponds to the magic number 34 here:

static void escSerialTimerTxConfig(const timerHardware_t *timerHardwarePtr, uint8_t reference)
{
uint32_t timerPeriod = 34;

Shall I remove it now?

@mikeller mikeller added this to the 4.0 milestone Dec 24, 2018

@mikeller

This comment has been minimized.

Copy link
Member

mikeller commented Dec 24, 2018

Earmarking this as a go-to for cherry-picking into 3.5 if targets are running out of flash space.

@mikeller mikeller merged commit ec64c89 into betaflight:master Dec 24, 2018

@jflyper jflyper deleted the jflyper:bfdev-escserial-simonk-separation branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.