Skip to content

Add STM32F411DISCOVERY target #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikeller merged 1 commit into from
Dec 29, 2018
Merged

Add STM32F411DISCOVERY target #7289

mikeller merged 1 commit into from
Dec 29, 2018

Conversation

@jonpas
Copy link
Contributor

@jonpas jonpas commented Dec 25, 2018 •
edited
Loading

This pull request adds STM32F411DISCO target for STM32F411Discovery board

  • Has "DISCO" appended to work around the target independent code test
    • Can name it "STM32F411DISCOVERY" if that would fit the others better?
    • Has been renamed to "STM32F411DISCOVERY" to fit other Discovery boards
  • Relies on Update L3GD20 gyro to modern gyro API. #7240 for gyro/acc sensor driver

Thanks to everyone on Slack for the help, especially @mikeller for updating the gyro/acc driver!

Review appreciated! :)
More pull requests likely coming as we find bugs/misconfiguration in the target.

~ by Team13, work done as part of a Drone student project

jflyper
jflyper previously approved these changes Dec 26, 2018
View reviewed changes
@mikeller mikeller added this to the 3.5.5 milestone Dec 26, 2018
mikeller
mikeller requested changes Dec 26, 2018
View reviewed changes
Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please rename as per comment.

Also, can you please add a markdown page into docs/boards/ describing the setup that you are using (external modules, wiring, schematic)? Photos are always welcome. :-)

src/main/target/STM32F411DISCO/target.h Outdated
Copy link
Member

@mikeller mikeller Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: There's another one that needs to be made runtime configurable.

@jonpas
Copy link
Contributor Author

jonpas commented Dec 26, 2018

Will add board docs and grab some pictures of the connected setup in the next days (have to take apart old drone assembled with F3 😃).

@jonpas jonpas changed the title Add STM32F411DISCO target Add STM32F411DISCOVERY target Dec 26, 2018
mikeller
mikeller previously approved these changes Dec 27, 2018
View reviewed changes
@jonpas
Copy link
Contributor Author

jonpas commented Dec 27, 2018 •
edited
Loading

Docs coming today.

mikeller
mikeller reviewed Dec 27, 2018
View reviewed changes
@jonpas
Copy link
Contributor Author

jonpas commented Dec 27, 2018

Verifying if motors work now.

@jonpas jonpas force-pushed the target-stm32f411 branch 2 times, most recently from 8c2e599 to 92eab77 Compare December 28, 2018 02:37
@jonpas
Copy link
Contributor Author

jonpas commented Dec 28, 2018 •
edited
Loading

Done for now.

  • Gyro/Acc/Mag work
  • PPM pin works
  • Motor pins work
  • Voltage/Current meters seem to be working (not really sure what expected result is)
  • Docs written with a full example from a student project linked (MIT licensed)

Is on par with STM32F3DISCOVERY target (unsure about STM32F4DISCOVERY as I don't have one).

All functions required for flying work (didn't actually fly it, need to modify frame).

Let me know if any other changes need to made or tested. I will open further PRs if people want extra peripheral support etc., seems pointless adding them myself as I have no way to test them at this time.

@mikeller mikeller merged commit a6fabe1 into betaflight:master Dec 29, 2018
@mikeller
Copy link
Member

mikeller commented Dec 29, 2018

@jonpas: Can you please test the STM32F411DISCOVERY target in the 3.5.x-maintenance branch to make sure the cherry-pick was correct?

mikeller added a commit that referenced this pull request Dec 29, 2018
@mikeller
Merge pull request #7289 from T-13/target-stm32f411
94a80e9 
Add STM32F411DISCOVERY target
@jonpas jonpas deleted the target-stm32f411 branch December 29, 2018 13:53
@jonpas
Copy link
Contributor Author

jonpas commented Dec 29, 2018

@mikeller Cherry-pick looks correct, but I will also give it a test run.

@jonpas
Copy link
Contributor Author

jonpas commented Dec 29, 2018

Works fine @mikeller! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeller mikeller mikeller approved these changes

@jflyper jflyper jflyper left review comments

Assignees

No one assigned

Labels

RN: NEW TARGET

Projects

None yet

Milestone

3.5.5

Development

Successfully merging this pull request may close these issues.

3 participants

@jonpas @mikeller @jflyper