Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add LED strip profile feature #7303
3 times, most recently
Dec 28, 2018
mikeller left a comment
This has a lot of overlap with something that I've been working on: Creating a 'minimal LED_STRIP' compile time option. The reason for this is that we are constantly running out of flash space on F3, and had to disable LED_STRIP support on F3 entirely in master for this reason. We want to bring back a minimal version of LED strip support that caters to the needs of racers, but keep the bloat that the rest of the LED strip code brings out of it. Doing this by splitting it into different 'LED_STRIP profiles', and not supporting the
@mikeller Interesting idea above, good to get a view of the bigger picture. I'm happy to change it to what you suggested or if you are far along with your changes just to rather adopt that - not fussed at all. I'll have a look at changing to your suggestion in the mean while and add the review changes above. Also, the race profile colors can already be changed in the OSD and CLI with the above changes. (Will be on holidays for a few days so might be a little slow to respond.)
@pkruger: My work on this was only very preliminary, as I was not able to come up with a good way to do the user interface for this - your idea with the profiles (and having the RACE / BEACON mode not be part of the complex STATUS configuration) provides an elegant solution for the part where I got stuck. So I'd go for your changes, making them built always for LED_STRIP and making the existing complex solution optional should do the trick nicely.
P.S.: Enjoy your holiday.