Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dyn filter options to OSD. #7306

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@kmitchel
Copy link
Contributor

kmitchel commented Dec 28, 2018

I've added a new submenu for the dynamic notch and gyro lowpass options. I left the dynamic dterm lowpass options in with the per profile options. I would like all the dynamic stuff in one menu, but I'm not sure if it's appropriate.

Show resolved Hide resolved src/main/cms/cms_menu_imu.c Outdated
Show resolved Hide resolved src/main/cms/cms_menu_imu.c Outdated

@mikeller mikeller added this to the 4.0 milestone Dec 29, 2018

@kmitchel kmitchel dismissed stale reviews from mikeller and fujin via 11e0882 Dec 31, 2018

@kmitchel kmitchel force-pushed the kmitchel:dyn_flt_osd branch 2 times, most recently from 11e0882 to a6aac6b Dec 31, 2018

@fujin
Copy link
Member

fujin left a comment

:shipit:

@fujin

This comment has been minimized.

Copy link
Member

fujin commented Dec 31, 2018

FLIP32F3OSD overflowin':

/home/travis/build/betaflight/betaflight/tools/gcc-arm-none-eabi-7-2018-q2-update/bin/../lib/gcc/arm-none-eabi/7.3.1/../../../../arm-none-eabi/bin/ld: obj/main/betaflight_FLIP32F3OSD.elf section `.bss' will not fit in region `RAM'
/home/travis/build/betaflight/betaflight/tools/gcc-arm-none-eabi-7-2018-q2-update/bin/../lib/gcc/arm-none-eabi/7.3.1/../../../../arm-none-eabi/bin/ld: region `RAM' overflowed by 8 bytes

@kmitchel kmitchel force-pushed the kmitchel:dyn_flt_osd branch 2 times, most recently from 740d433 to 8bdd3b5 Dec 31, 2018

@gvhlaw

This comment has been minimized.

Copy link

gvhlaw commented Dec 31, 2018

I've tested it - and it sure makes life easy! Works great.

@fujin
Copy link
Member

fujin left a comment

LGTM assuming the removal of extended CMS menu from spracingf3 is OK 👍 :shipit:

Show resolved Hide resolved src/main/cms/cms_menu_imu.c Outdated
Add dyn filter options to OSD.
Fix FLIP32F3OSD target.

Fix trailing whitespace.

@kmitchel kmitchel force-pushed the kmitchel:dyn_flt_osd branch from 8bdd3b5 to 257a09d Jan 2, 2019

@mikeller mikeller merged commit 40279f3 into betaflight:master Jan 8, 2019

@kmitchel kmitchel deleted the kmitchel:dyn_flt_osd branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.