Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RSSI and Link Quality warnings #8017

Merged
merged 3 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@ianrmurphy
Copy link
Contributor

commented Apr 14, 2019

Implements #8001.

Previously low RSSI alarm would only cause the RSSI OSD field to flash. This pull request implements RSSI Low as a warning. A Link Quality alarm and warning has also been added.

RSSI and Link Quality warnings have been prioritised after the arming / take-off warnings but before all other in-flight warnings.

@ianrmurphy ianrmurphy changed the title Rssi lq warnings Added RSSI and Link Quality warnings Apr 14, 2019

@ianrmurphy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Can be tested with CLI settings osd_warn_rssi = ON, osd_warn_link_quality = ON. Link Quality alarm level can be set using osd_link_quality_alarm (default = 80%).

Or use betaflight/betaflight-configurator#1384 as Configurator.

@ianrmurphy ianrmurphy force-pushed the ianrmurphy:rssi-lq-warnings branch from aa4bc12 to 11dd4e7 Apr 14, 2019

@@ -222,6 +224,7 @@ typedef struct osdConfig_s {
uint16_t cap_alarm;
uint16_t alt_alarm;
uint8_t rssi_alarm;
uint8_t link_quality_alarm;

This comment has been minimized.

Copy link
@mikeller

mikeller Apr 15, 2019

Member

This has to go at the end of the parameter group, or else it will break it: https://github.com/betaflight/betaflight/blob/master/docs/development/ParameterGroups.md

@mikeller mikeller added this to the 4.1 milestone Apr 15, 2019

@@ -809,6 +809,13 @@ static bool mspCommonProcessOutCommand(uint8_t cmdMSP, sbuf_t *dst, mspPostProce
sbufWriteU8(dst, 0);
#endif // USE_OSD_STICK_OVERLAY

// API >= 1.42
#ifdef USE_RX_LINK_QUALITY_INFO

This comment has been minimized.

Copy link
@mikeller

mikeller Apr 15, 2019

Member

As per convention in Betaflight, new features should be added CLI only for the first release, so this should only be added after 4.1 has been released.

@ianrmurphy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Issues addressed.

@@ -203,6 +203,8 @@ typedef enum {
OSD_WARNING_LAUNCH_CONTROL,
OSD_WARNING_GPS_RESCUE_UNAVAILABLE,
OSD_WARNING_GPS_RESCUE_DISABLED,
OSD_WARNING_RSSI,
OSD_WARNING_LINK_QUALITY,

This comment has been minimized.

Copy link
@etracer65

etracer65 Apr 15, 2019

Member

Extra whitespace.

This comment has been minimized.

Copy link
@ianrmurphy

ianrmurphy Apr 15, 2019

Author Contributor

Corrected.

@etracer65

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Also support for the extra warnings elements will need to be need to be added to the Configurator.

@ianrmurphy

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

Configurator support is here: betaflight/betaflight-configurator#1384.

@mikeller mikeller merged commit db5c14d into betaflight:master Apr 16, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.