Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assignment of random timer for pins without configured timer option. #8093

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
4 participants
@mikeller
Copy link
Member

commented Apr 25, 2019

Fixes #8066, #8071.

@mikeller mikeller merged commit 2df780a into betaflight:master Apr 27, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@mikeller mikeller deleted the mikeller:fix_invalid_timer_index branch Apr 27, 2019

mikeller added a commit that referenced this pull request Apr 27, 2019

Fixed assignment of random timer for pins without configured timer op…
…tion. (#8093)

Fixed assignment of random timer for pins without configured timer option.
@andrejpodzimek

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Just FYI, this change breaks FF_KOMBINI; it renders motors inoperable (e.g.) on the Moskito 70, for both DShot and analog protocols. Reverting this solves the problem. With this change, motors won't appear in resource show or dma show.

I know that it's an F3, so it's no longer supported and will only work up until 4.0.0. So I'm just dropping this piece of information here, in case if someone wants to try and build FF_KOMBINI from code after this change.

@andrejpodzimek

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

So this seems to have a few more consequences, like #8142.

@jflyper

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

@andrejpodzimek You may want to test the FF_KOMBINI firmware posted in #8148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.