Avoid recalculation of ADC vrefMv, add vrefMv to ADC_INTERNAL debug mode. #8427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Jun 15, 2019
mikeller
approved these changes
Jun 17, 2019
mikeller
added a commit
that referenced
this pull request
Jul 24, 2019
…ode. (#8427) Avoid recalculation of ADC vrefMv, add vrefMv to ADC_INTERNAL debug mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adcinternal.c, coreTemperature is always calculated every time adcInternalProcess is called, which internally calls getVrefMv(), the result of which is thrown away at the end of the method. later calls to adcVrefMv() will then recalculate the value.
this seems a little wasteful, is there a reason why we don't calculate
adcVrefMvonce, and store it like we do forcoreTemperature?This PR addresses this question.