Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 8, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the magnetometer I2C bus for the SKYSTARSH7HD target, improving sensor detection and initialization and reducing startup errors.
  • Chores

    • Updated timer pin mappings and DMA/ADC assignment defaults for SKYSTARSH7HD to improve peripheral timing, ADC/DMA reliability, and hardware stability.

@haslinghuis haslinghuis self-assigned this Oct 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Updated SKYSTARSH7HD board configuration: reorganized TIMER_PIN_MAPPING entries, reindexed and changed several DMA option macros, and changed MAG_I2C_INSTANCE from I2CDEV_2 to I2CDEV_1 in configs/SKYSTARSH7HD/config.h.

Changes

Cohort / File(s) Summary
Board config: timer pin mapping
configs/SKYSTARSH7HD/config.h
Replaced and reindexed TIMER_PIN_MAPPING entries for timer indices 8–17, leaving new entries for indices 8–11 and using -1 placeholders where appropriate.
Board config: DMA options
configs/SKYSTARSH7HD/config.h
Updated ADC and TIMUP DMA option macros: ADC1_DMA_OPT 8→9, ADC3_DMA_OPT 9→10, TIMUP3_DMA_OPT 2→11, TIMUP4_DMA_OPT 1→12, TIMUP5_DMA_OPT 0→13; removed TIMUP1_DMA_OPT, TIMUP2_DMA_OPT, TIMUP8_DMA_OPT.
Board config: magnetometer I2C
configs/SKYSTARSH7HD/config.h
Set MAG_I2C_INSTANCE from I2CDEV_2 to I2CDEV_1.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

Bugfix

Suggested reviewers

  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning There is no pull request description present, so none of the required sections from the repository’s template—such as hardware compliance notes, branch housekeeping information, or the checklist—are included. Add a description that follows the repository template by including the “Pull-Request requirements” header, mandatory hardware review details, branch housekeeping notes, and a filled checklist indicating schematics review, hardware testing, guideline compliance, and flight testing status.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately and concisely describes a significant change in the pull request by naming the MAG_I2C_INSTANCE update, and it refers to a real part of the modifications without using vague language. Although the PR also adjusts DMA options and timer mappings, the title remains clear and specific rather than generic or misleading.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch haslinghuis-patch-3

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f0152d and de33533.

📒 Files selected for processing (1)
  • configs/SKYSTARSH7HD/config.h (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • configs/SKYSTARSH7HD/config.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot
Copy link
Contributor

ot0tot commented Oct 11, 2025

Let's fix the DMA requests as well.

@haslinghuis haslinghuis merged commit 116c557 into master Oct 14, 2025
2 checks passed
@haslinghuis haslinghuis deleted the haslinghuis-patch-3 branch October 14, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants