Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ajoute rubocop-rails #1321

Merged
merged 16 commits into from Apr 15, 2021
Merged

ajoute rubocop-rails #1321

merged 16 commits into from Apr 15, 2021

Conversation

yaf
Copy link
Contributor

@yaf yaf commented Apr 8, 2021

close #1287

@yaf
Copy link
Contributor Author

yaf commented Apr 9, 2021

@n-b amusant de voir que le linter rubocop-rails force l'usage de Time.zone.today plutôt que Date.today 😄

Je vais laisser dans le rubocop-todo.yml pour le moment. Je partage cependant l'avis d'Adrien sur le fait de ne pas garder ce fichier trop longtemps... Qu'en pense tu ?

@n-b
Copy link
Contributor

n-b commented Apr 12, 2021

rubocop-rails force l'usage de Time.zone.today plutôt que Date.today

Oui, j’avais vu ça :)

Et pareil, je suis assez partisan de faire en sorte de se débarasser de rubocop-todo.yml rapidement.

@n-b
Copy link
Contributor

n-b commented Apr 15, 2021

Patché-rebasé, ça devrait passer la CI. Il reste encore pas mal de choses dans rubocop_todo, mais c’est déjà un début.

@n-b n-b marked this pull request as ready for review April 15, 2021 16:23
@yaf yaf enabled auto-merge (squash) April 15, 2021 17:22
@yaf
Copy link
Contributor Author

yaf commented Apr 15, 2021

Comme elle est ouverte par moi, je ne peux pas la valider. Mais ça me semble ok.

@yaf yaf merged commit c5369f2 into master Apr 15, 2021
@yaf yaf deleted the ajoute-linter-rails branch April 15, 2021 17:53
@n-b n-b mentioned this pull request Apr 27, 2021
2 tasks
@n-b n-b mentioned this pull request May 5, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajout d'un linter pour Rails
2 participants