Implement a simple HttpClient wrapper as an alternative to using a proxy #40

Closed
robfletcher opened this Issue Oct 13, 2011 · 4 comments

Projects

None yet

1 participant

@robfletcher
Collaborator

In many scenarios it would be trivial to inject a Betamax wrapper around a standard HttpClient instance into the class-under-test. This would be simpler than spinning up a proxy server and could share all the same functionality.

@robfletcher robfletcher was assigned Sep 26, 2012
@robfletcher
Collaborator

Following recent refactoring this is almost trivial to implement so I might do so for 1.1

@robfletcher robfletcher pushed a commit that referenced this issue Sep 26, 2012
Rob Fletcher Proof of concept implementation for #40 f9eb010
@robfletcher robfletcher pushed a commit that referenced this issue Sep 26, 2012
Rob Fletcher more implementation for #40 c62bb6f
@robfletcher robfletcher pushed a commit that referenced this issue Sep 26, 2012
Rob Fletcher preliminary doc changes for #40 766f465
@robfletcher
Collaborator

Since SystemDefaultHttpClient exists I don't think there's any need for this.

@robfletcher
Collaborator

whoops, that was completely the wrong issue I closed

@robfletcher robfletcher reopened this Oct 23, 2012
@robfletcher robfletcher pushed a commit that referenced this issue Oct 23, 2012
Rob Fletcher #40 pick up `useProxy` from config 91876e3
@robfletcher robfletcher pushed a commit that referenced this issue Oct 23, 2012
Rob Fletcher #40 document `useProxy` flag ccc8e36
@robfletcher robfletcher pushed a commit that referenced this issue Oct 23, 2012
Rob Fletcher #40 use `useProxy` in the test for BetamaxHttpClient c602ae7
@robfletcher robfletcher pushed a commit that referenced this issue Oct 23, 2012
Rob Fletcher docs for #40 9119185
@robfletcher
Collaborator

This is in master now (and deployed as Betamax 1.2-SNAPSHOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment