Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Concurrency tests #129

Merged
merged 6 commits into from Jan 29, 2014

Conversation

Projects
None yet
2 participants
Contributor

dkowis commented Jan 29, 2014

So this just puts up some concurrent execution tests. Guaranteeing that Betamax is able to serve concurrent requests nicely.

It also flushed out a problem with the content-length header being set to something such that it's not calculated again when an individual modifies the response, but that's a different bug.

dkowis and others added some commits Jan 27, 2014

Created a failing test
So it fails playback when doing things concurrently using the
AsyncHttpClient from Apache Http Components.

This is similar to the behavior I found when I ran the proxy standalone.
Of note is that it doesn't seem to fail if the tape is READ_WRITE. Will
have to add a test to demonstrate that as well, then refactor all the
duplicated code out.
Modified the test to do both tape modes
Now it's a bit more configurable, and no repeat code. yay
a small change or two to the BetamaxFilters
Mostly a TODO note with regards to how to handle the CONNECT part.

And then using a ProxyUtils method that was mentioned in the
littleproxy javadocs instead of doing the same check ourselves. It reads
a bit nicer.

robfletcher added a commit that referenced this pull request Jan 29, 2014

@robfletcher robfletcher merged commit 8ac02ec into betamaxteam:master Jan 29, 2014

Collaborator

robfletcher commented Jan 29, 2014

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment