Fixing an instance where http handlers could change the header state of a stored request. #75

Closed
wants to merge 0 commits into
from

Conversation

Projects
None yet
3 participants
Collaborator

cowboygneox commented Feb 6, 2013

Prior to this fix, a request could be stored, and if it were replayed in the same tape session, it would add an X-Betamax header to the stored request. In this case, the tape would be written with these X-Betamax headers in them, and in my particular use case, would result in the occasional parse error.

The YAML should never contain any of the X-Betamax headers when persisted.

Collaborator

cowboygneox commented Feb 6, 2013

It would be incredible if we could integrate this into the 1.2-SNAPSHOT in the near future. I would much prefer to use managed dependencies in my projects.

Thanks!

Collaborator

robfletcher commented Jul 2, 2013

I will definitely merge this in. I'm in the middle of a fairly large refactor, though – hence the delay.

Collaborator

cowboygneox commented Aug 5, 2013

@robfletcher This project is of pretty large interest to me. I am interested in becoming a contributor to help jump this project into a more recently updated status. Would you care to enlist my free labor?

Collaborator

robfletcher commented Aug 5, 2013

Sure. I've just started working on a couple of large issues that will be the core of the next release – #66 and #85. I have just merged the feature branch I've been working on into master. It looks like that means some changes would need to be made to this pull request – probably just because the project has been split into multiple modules. It would be great to get some kind of a test to prove this change works as well. It's not immediately obvious from the change itself why this works where the previous implementation didn't.

I'd definitely like to have more regular contributors to the project – if there are other features you'd be interested in working on let me know.

Collaborator

cowboygneox commented Aug 5, 2013

@robfletcher If there is a way to send you a private message on GitHub, I am not aware. Do you want to continue to discuss here?

Collaborator

robfletcher commented Aug 5, 2013

I don't mind to carry on here but if you'd rather discuss privately you can email me rob@Betamax's maven group

Collaborator

cowboygneox commented Aug 5, 2013

@robfletcher Email sent. Let me know if you didn't get it.

Contributor

pledbrook commented Aug 9, 2013

Ah, so this is probably the issue I've been running into. 👍 for the merge!

Collaborator

cowboygneox commented Aug 9, 2013

@pledbrook The repository is currently in a state of flux, but let me know if you need a short-term solution for this.

Collaborator

robfletcher commented Aug 9, 2013

I'm creating a 1.1.x branch to try to merge in this & @pledbrook's changes for a 1.1.3 release.

Collaborator

cowboygneox commented Aug 9, 2013

@robfletcher Awesome :)

Collaborator

robfletcher commented Aug 9, 2013

Hmm actually it could be tricky. It looks like this change was made against a later version of code than 1.1.2

Collaborator

cowboygneox commented Aug 9, 2013

@robfletcher Yeah I don't doubt it. When I wrote this change, I did it against master thinking it could make it into 1.1.3.

cowboygneox closed this Aug 9, 2013

cowboygneox reopened this Aug 9, 2013

Collaborator

cowboygneox commented Aug 9, 2013

@robfletcher Do you want me to apply this to a 1.1.2 branch?

Collaborator

robfletcher commented Aug 9, 2013

Ah I think I just need to baseline from a layer revision

On Friday, August 9, 2013, Sean Freitag wrote:

@robfletcher https://github.com/robfletcher Yeah I don't doubt it. When
I wrote this change, I did it against master thinking it could make it into
1.1.3.


Reply to this email directly or view it on GitHubhttps://github.com/robfletcher/betamax/pull/75#issuecomment-22392106
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment