Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup zipkin transport dependencies #102

Open
eswdd opened this issue Jul 18, 2015 · 3 comments
Open

Cleanup zipkin transport dependencies #102

eswdd opened this issue Jul 18, 2015 · 3 comments
Milestone

Comments

@eswdd
Copy link
Contributor

eswdd commented Jul 18, 2015

Currently inclusion of zipkin triggers inclusion of socket and jetty transports. This is bad for clients and less than ideal for servers. Additionally whilst we can exclude dependencies, certain config will fail if we do (for example socket port which if socket transport not included will fail to parse to an int and throw and exception at start).

This needs resolving prior to 3.3 release.

@eswdd eswdd added this to the Release 3.3.0 milestone Jul 18, 2015
@HugoMFernandes
Copy link

Hey Simon,

Can you elaborate on this so I know what needs to be picked up? A list of things that really need solving before a 3.3 release would be helpful.

Cheers.

@eswdd
Copy link
Contributor Author

eswdd commented Nov 12, 2015

Hi Hugo
There's not much more to say except what's in the description. If you're using the Cougar client in another app then you pull in minimal dependencies. If you then want Zipkin support in that client, then inclusion of the cougar-zipkin dependency pulls in far more - this we don't want. I haven't looked further to see how best to solve. This is the only blocker for a 3.3 release AFAIK.

@andredasilvapinto
Copy link
Contributor

#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants