From 98a45d0853c5f8a7a808d282059bbeb5908dfd11 Mon Sep 17 00:00:00 2001 From: Maciej Brencz Date: Tue, 19 Jan 2021 13:33:59 +0100 Subject: [PATCH 1/5] Try to run tests using Python 3.9 See https://github.com/bethinkpl/chronos/pull/119 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5fe7309..ca3abcb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: - python-version: [3.8] + python-version: [3.9] steps: - uses: actions/checkout@v2 From 5a5ac26527e703bba659049de5b07727f61c014f Mon Sep 17 00:00:00 2001 From: Maciej Brencz Date: Tue, 19 Jan 2021 13:47:32 +0100 Subject: [PATCH 2/5] Test using both Python 3.8 and 3.9 Co-authored-by: Milosz Bednarzak <33376065+miloszbednarzak@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca3abcb..d563571 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: - python-version: [3.9] + python-version: [3.8, 3.9] steps: - uses: actions/checkout@v2 From 7d9a7587bc130883c7146991aef88cf4ac5a440f Mon Sep 17 00:00:00 2001 From: Maciej Brencz Date: Wed, 20 Jan 2021 10:59:38 +0100 Subject: [PATCH 3/5] Disable tests with Python 3.9 Waiting for Python 3.9-compatible pylint --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d563571..23dd950 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,9 @@ jobs: strategy: matrix: - python-version: [3.8, 3.9] + python-version: + - "3.8" + #- "3.9" # disabled for now, waiting for Python 3.9-compatible pylint steps: - uses: actions/checkout@v2 From 682bc8df6bc25a833895bb62c550c606f83b1f85 Mon Sep 17 00:00:00 2001 From: Maciej Brencz Date: Wed, 20 Jan 2021 17:31:23 +0100 Subject: [PATCH 4/5] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 23dd950..16ed369 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: matrix: python-version: - "3.8" - #- "3.9" # disabled for now, waiting for Python 3.9-compatible pylint + - "3.9" steps: - uses: actions/checkout@v2 From 586474202b8be0fec63d0e83a132e03d6e5871c1 Mon Sep 17 00:00:00 2001 From: macbre Date: Fri, 5 Mar 2021 10:25:09 +0100 Subject: [PATCH 5/5] Make pylint happy (too-few-public-methods) --- src/pythink_toolbox/testing/parametrization.py | 1 + tests/test_testing/test_paramatrization.py | 7 ++++--- tests/test_validating.py | 5 +++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/pythink_toolbox/testing/parametrization.py b/src/pythink_toolbox/testing/parametrization.py index 00bbbdd..83ed13f 100644 --- a/src/pythink_toolbox/testing/parametrization.py +++ b/src/pythink_toolbox/testing/parametrization.py @@ -4,6 +4,7 @@ import pytest +# pylint:disable=too-few-public-methods class Scenario(TypedDict): """Default scenario for parametrization. Examples: diff --git a/tests/test_testing/test_paramatrization.py b/tests/test_testing/test_paramatrization.py index 86e5a69..2e6fb38 100644 --- a/tests/test_testing/test_paramatrization.py +++ b/tests/test_testing/test_paramatrization.py @@ -1,6 +1,7 @@ -# pylint: disable=missing-class-docstring -# pylint: disable=missing-function-docstring -# pylint: disable=protected-access +# pylint:disable=missing-class-docstring +# pylint:disable=missing-function-docstring +# pylint:disable=protected-access +# pylint:disable=too-few-public-methods import typing import pythink_toolbox.testing.parametrization as tested_module diff --git a/tests/test_validating.py b/tests/test_validating.py index 50fb06d..a07de2c 100644 --- a/tests/test_validating.py +++ b/tests/test_validating.py @@ -1,5 +1,6 @@ -# pylint: disable=missing-class-docstring -# pylint: disable=missing-function-docstring +# pylint:disable=missing-class-docstring +# pylint:disable=missing-function-docstring +# pylint:disable=too-few-public-methods from typing import Any, Type, Callable, List, Optional import pandera # type: ignore[import]