Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on requests #2

Merged

Conversation

Projects
None yet
2 participants
@sturmer
Copy link

commented Jun 19, 2019

Hi @betodealmeida,

This might be my profound ignorance of how Python works but it seems to me that requests is not used anywhere in this project. I propose to remove the dependency as it is problematic for superset (see apache/incubator-superset#7643).

Obrigado,
Gianluca

@sturmer sturmer referenced this pull request Jun 19, 2019

Open

7620: Start removing dependencies on requests #7643

2 of 12 tasks complete
@betodealmeida

This comment has been minimized.

Copy link
Owner

commented Jun 19, 2019

You're right! Thanks for catching this! :)

@betodealmeida betodealmeida merged commit 23b6663 into betodealmeida:master Jun 19, 2019

@sturmer sturmer deleted the sturmer:remove-requests-dependency branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.