Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on requests #2



Copy link

@sturmer sturmer commented Jun 19, 2019

Hi @betodealmeida,

This might be my profound ignorance of how Python works but it seems to me that requests is not used anywhere in this project. I propose to remove the dependency as it is problematic for superset (see apache/superset#7643).


Copy link

You're right! Thanks for catching this! :)

@betodealmeida betodealmeida merged commit 23b6663 into betodealmeida:master Jun 19, 2019
@sturmer sturmer deleted the remove-requests-dependency branch June 20, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants