pass ignore_unknown_fields to nested structs #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #152
This passes
ignore_unknown_fieldsto_value_from_dict(), and passes that tomsg_cls.from_dict().Note that if you're worried about this being a maintenance problem if more parameters are added to
from_dict(), I think I can update it to use https://docs.python.org/3/library/typing.html#typing.Unpack to define thefrom_dict()args, but that might be overkill for now.Checklist