Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions with type number are converted to undefined #6

Closed
Hurtak opened this issue Jul 9, 2015 · 3 comments
Closed

Suggestions with type number are converted to undefined #6

Hurtak opened this issue Jul 9, 2015 · 3 comments
Labels

Comments

@Hurtak
Copy link
Contributor

Hurtak commented Jul 9, 2015

horsey(document.getElementById('test'), {
    suggestions: ['aaa', 100, 200, 300]
});

will produce

http://i.imgur.com/QlqbUmr.png

@bevacqua bevacqua added the bug label Jul 14, 2015
@bevacqua
Copy link
Owner

These two methods should be fixed: https://github.com/bevacqua/horsey/blob/master/horsey.js#L502-L508

Care to create a PR?

@Hurtak
Copy link
Contributor Author

Hurtak commented Jul 14, 2015

Can't promise anything, but i will take a look at it tomorrow.

-----Original Message-----
From: "Nicolas Bevacqua" notifications@github.com
Sent: ‎14. ‎7. ‎2015 23:01
To: "bevacqua/horsey" horsey@noreply.github.com
Cc: "Petr Huřťák" petr.hurtak@gmail.com
Subject: Re: [horsey] Suggestions with type number are converted to undefined(#6)

These two methods should be fixed: https://github.com/bevacqua/horsey/blob/master/horsey.js#L502-L508
Care to create a PR?

Reply to this email directly or view it on GitHub.

@bevacqua
Copy link
Owner

Resolved in 2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants