fix horsey on IE 9+ #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works better across browsers as the previous attempt to capture focus on the documentElement did not work on IE (the target is set incorrectly)
dereke
changed the title
|
Originally I was trying to listen to the onpointerdown event in IE, however it turned out that the actual issue was that we were listening to the focus event on the document element and in IE the target of that event is the document rather than the element which received the focus (like it is in chrome/firefox). The focus event was being used to hide the list if the target was not an item in the list. Obviously in IE the target was never an item in the list so this would not work and you could never select an item with the mouse. This change listens to the keydown event and if the tab key is pressed then it hides the list. It relies on autoHideOnClick being true to hide the list in the case that some other element is clicked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix for issue #23