New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetch line info if a new `debug` config option is true (false by default) #16

Open
balupton opened this Issue May 3, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@balupton
Member

balupton commented May 3, 2016

Update catepillar-human to use debug property.

This will be a major breaking change. As instead of just doing .setConfig({level: 7}) if they want debugging, they must now also do .setConfig({debug: true, level: 7}).

So will need to have to do something for this... Perhaps something like:

const config = this.getConfig()
const debug = config.debug != null ? config.debug : config.level === 7

However, if we specify a default like false, then the above won't work.

Maybe just gotta break b/c compat.

Would also be interesting to see the performance comparison of this.

@balupton

This comment has been minimized.

Member

balupton commented May 3, 2016

I suspect this would be a huge performance increase when not in debug mode. As fetching those lines is quite intensive if doing thousands of logs a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment