Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag for bypassing default error pages #251

Merged
merged 4 commits into from Jul 19, 2012
Merged

Flag for bypassing default error pages #251

merged 4 commits into from Jul 19, 2012

Conversation

ncrohn
Copy link
Contributor

@ncrohn ncrohn commented Jun 28, 2012

Added in a docpad config variable to allow the errors plugin to function.

This allows for the server to respond in a custom fashion to 404 pages and the like.

@balupton
Copy link
Member

balupton commented Jul 1, 2012

Sweet, good work!

The plugin you've created for this could probably go straight into the core too. What are your thoughts?

@ncrohn
Copy link
Contributor Author

ncrohn commented Jul 2, 2012

I think that probably makes a lot of sense. I will get the plugin moved over to core today and added to this pull request.

@ncrohn
Copy link
Contributor Author

ncrohn commented Jul 2, 2012

Moved the error plugin to the core page handling, also changed the name of the custom errors flag to useCustomErrors. I had it removed but thought better of it for people wanting to use an htaccess file.

Let me know what you think.

@ncrohn
Copy link
Contributor Author

ncrohn commented Jul 12, 2012

Do you have any other feedback on this addition? The recent commit drops the excessive error handling.

@balupton
Copy link
Member

Sweet. Didn't spot that last commit. Will merge in soon :)

@ncrohn
Copy link
Contributor Author

ncrohn commented Jul 18, 2012

Wanted to check on the status, we are currently running off of a fork for this and would be nice to have it in your deployed version of docpad. Let me know if there is anything else I can do. Thanks again!

@balupton
Copy link
Member

Doing it now :)

balupton added a commit that referenced this pull request Jul 19, 2012
@balupton
Pulled #251, Fixed #269, #268
b52226c 
We now only clear the meta attributes from the document attributes on a
new parse. Instead of clearing everything. Other parsing optimisations
were also made.

File IDs are now also the relativePath instead of the relativeBase to
avoid collisions.
@balupton balupton merged commit 09de510 into docpad:master Jul 19, 2012
@balupton
Copy link
Member

Published in v6.4.0

@balupton
Copy link
Member

Btw, working fantastic on the kitchensink site: http://docpad-kitchensink.herokuapp.com/asdasdsad

:D

@ncrohn
Copy link
Contributor Author

ncrohn commented Jul 19, 2012

Awesome! Thanks for getting this in!

balupton added a commit that referenced this pull request Oct 23, 2013
@balupton
Pulled #251, Fixed #269, #268
cadbcf3 
We now only clear the meta attributes from the document attributes on a
new parse. Instead of clearing everything. Other parsing optimisations
were also made.

File IDs are now also the relativePath instead of the relativeBase to
avoid collisions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncrohn @balupton