Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex for parseSync so we always ignore lines starting with # #9

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@andyedwardsdfdl
Copy link
Contributor

andyedwardsdfdl commented Jan 4, 2017

I have added a test that includes one comment line, and updated the regular expression such that any line starting with a '#' but also containing a '=' is ignored.

@balupton

This comment has been minimized.

Copy link
Member

balupton commented Feb 7, 2017

LGTM - will add to merge queue

Initially I thought of adding a if ( line[0] === '#' ) continue line, but your solution is just as good and cleaner in comparison.

@balupton balupton merged commit e8bf0ee into bevry:master Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@balupton

This comment has been minimized.

Copy link
Member

balupton commented Jan 25, 2018

Sorry this took so long for merge and release

balupton added a commit that referenced this pull request Jan 25, 2018

@andyedwardsdfdl andyedwardsdfdl deleted the andyedwardsdfdl:ignore-env-comments branch Jan 25, 2018

@BevryMe

This comment has been minimized.

Copy link
Member

BevryMe commented Jul 24, 2018

This pull request has been mentioned on Bevry's Discourse. There might be relevant details there:

https://discuss.bevry.me/t/how-the-node-module-envfile-handles-comments/121/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.