Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMac() allows non-hex octets #38

Closed
chrisbartley opened this issue Jul 17, 2018 · 1 comment
Closed

isMac() allows non-hex octets #38

chrisbartley opened this issue Jul 17, 2018 · 1 comment

Comments

@chrisbartley
Copy link

@chrisbartley chrisbartley commented Jul 17, 2018

require('getmac').isMac('gh:ij:kl:mn:op:qr') incorrectly returns true.

Looks like the regex is wrong (a-z instead of a-f). This one looks to be correct: https://stackoverflow.com/a/4260512/703200

@balupton

This comment has been minimized.

Copy link
Member

@balupton balupton commented Nov 18, 2019

please submit a PR

@balupton balupton closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.