Skip to content

Fix hasModel() cid lookup for Backbone > 0.9.9 #21

Merged
merged 1 commit into from Jan 21, 2013

2 participants

@nfm
nfm commented Jan 21, 2013

The _byCid object and getByCid() have been removed as on Backbone 0.9.9. get() now supports lookup by both id and cid.

Conditionally use _byCid implementation for backwards compatibility.

@nfm nfm Fix hasModel() cid lookup for Backbone > 0.9.9
The `_byCid` object and `getByCid()` have been removed. `get()` now supports lookup by both id and cid. Keep `_byCid` implementation for backwards compatibility.
2ed525d
@balupton balupton merged commit 5ebf36a into bevry:master Jan 21, 2013
@balupton

Sweet. I'll clean it to (@_byCid?[model.cid] or @get(model.cid)) which produces the same result.

@balupton balupton added a commit that referenced this pull request Jan 24, 2013
@balupton balupton Cleaned pull request #21 09da9eb
@balupton balupton added a commit that referenced this pull request Jan 24, 2013
@balupton balupton v1.5.1. Bugfix. Improvement.
- v1.5.1 January 24, 2013
	- Support for Backbone v0.9.10
		- Closes [pull request
#21](#21) thanks to [Nicholas
Firth-McCoy](https://github.com/nfm)
	- Added backbone as a peerDependency
ea7a1e5
@balupton balupton added a commit that referenced this pull request Jan 24, 2013
@balupton balupton v1.5.1. Bugfix. Improvement.
- v1.5.1 January 24, 2013
	- Support for Backbone v0.9.10
		- Closes [pull request
#21](#21) thanks to [Nicholas
Firth-McCoy](https://github.com/nfm)
	- Added backbone as a peerDependency
26cf4f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.