Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

v3.3.4. Bugfix.

  • Loading branch information...
commit 0c8f76614bfe225e13216d6bb1faf5adff3d74e7 1 parent d8d0453
@balupton balupton authored
View
5 .gitignore
@@ -10,3 +10,8 @@ components/
bower_components/
node_modules/
out/
+
+# =====================================
+# CUSTOM MODIFICATIONS
+
+# None
View
7 .npmignore
@@ -23,4 +23,9 @@ HISTORY.md
# Other Package Definitions
template.js
component.json
-bower.json
+bower.json
+
+# =====================================
+# CUSTOM MODIFICATIONS
+
+# None
View
4 .travis.yml
@@ -1,7 +1,7 @@
-# v1.3.2 October 26, 2013
+# v1.3.8 November 7, 2013
# https://github.com/bevry/base
language: node_js
-install: "npm install"
+install: "npm install; ./node_modules/.bin/cake install"
before_script: "./node_modules/.bin/cake compile"
script: "npm test"
node_js:
View
47 CONTRIBUTING.md
@@ -1,15 +1,31 @@
+<!--
+v1.3.9 November 17, 2013
+https://github.com/bevry/base
+-->
+
+
# Contribute
+
## Development
-1. Fork the project and clone your fork
+For developers and contributors
+
+1. Fork project and clone your fork
+
2. Install global dependencies
``` bash
npm install -g coffee-script
```
-3. Compile the project
+3. Install local dependencies
+
+ ``` bash
+ cake install
+ ```
+
+4. Compile project
``` bash
# Only once
@@ -19,20 +35,41 @@
cake watch
```
-4. Run your tests
+5. Run tests
``` bash
cake test
```
-5. Prepare the project for publishing
+
+## Publishing
+
+For project maintainers
+
+1. Update meta files with latest information
``` bash
cake prepublish
```
-6. Publish the project
+2. Add a changelog entry to `HISTORY.md` with change information
+
+ ```
+ v2.0.0 April 17, 2013
+ - Something that changes
+ ```
+
+3. Update `version` entry in `package.json` with new version number
+
+4. Commit changes
``` bash
+ git commit -a -m "A message about what changed"
+ ```
+
+5. Publish new version
+
+ ``` bash
cake publish
```
+
View
10 Cakefile
@@ -1,4 +1,4 @@
-# v1.3.4 October 30, 2013
+# v1.3.8 November 7, 2013
# https://github.com/bevry/base
@@ -25,6 +25,7 @@ SRC_DIR = pathUtil.join(APP_DIR, "src")
OUT_DIR = pathUtil.join(APP_DIR, "out")
TEST_DIR = pathUtil.join(APP_DIR, "test")
MODULES_DIR = pathUtil.join(APP_DIR, "node_modules")
+DOCPAD_DIR = pathUtil.join(MODULES_DIR, "docpad")
BIN_DIR = pathUtil.join(MODULES_DIR, ".bin")
GIT = "git"
CAKE = pathUtil.join(BIN_DIR, "cake#{EXT}")
@@ -87,7 +88,12 @@ actions =
fsUtil.exists TEST_DIR, (exists) ->
return next() unless exists
# npm install (for test)
- spawn(NPM, ['install'], {stdio:'inherit', cwd:TEST_DIR}).on('close', safe next)
+ spawn(NPM, ['install'], {stdio:'inherit', cwd:TEST_DIR}).on('close', safe next, step3)
+ step3 = ->
+ fsUtil.exists DOCPAD_DIR, (exists) ->
+ return next() unless exists
+ # npm install (for test)
+ spawn(NPM, ['install'], {stdio:'inherit', cwd:DOCPAD_DIR}).on('close', safe next)
step1()
compile: (opts,next) ->
View
3  History.md
@@ -1,5 +1,8 @@
# History
+- v3.3.4 November 27, 2013
+ - Fixed the v3.3.3 fix
+
- v3.3.3 November 27, 2013
- Fixed possible "(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral." error under certain circumstances
View
2  README.md
@@ -7,6 +7,7 @@
<!-- BADGES/ -->
+[![Build Status](http://img.shields.io/travis-ci/bevry/taskgroup.png?branch=master)](http://travis-ci.org/bevry/taskgroup "Check this project's build status on TravisCI")
[![NPM version](http://badge.fury.io/js/taskgroup.png)](https://npmjs.org/package/taskgroup "View this project on NPM")
[![Gittip donate button](http://img.shields.io/gittip/bevry.png)](https://www.gittip.com/bevry/ "Donate weekly to this project using Gittip")
[![Flattr donate button](http://img.shields.io/flattr/donate.png?color=yellow)](http://flattr.com/thing/344188/balupton-on-Flattr "Donate monthly to this project using Flattr")
@@ -36,6 +37,7 @@ Group together synchronous and asynchronous tasks and execute them with support
<!-- /INSTALL -->
+
## Contents
1. [Usage](#usage)
View
2  package.json
@@ -1,7 +1,7 @@
{
"title": "TaskGroup",
"name": "taskgroup",
- "version": "3.3.3",
+ "version": "3.3.4",
"description": "Group together synchronous and asynchronous tasks and execute them with support for concurrency, naming, and nesting.",
"homepage": "https://github.com/bevry/taskgroup",
"license": {
View
4 src/lib/taskgroup.coffee
@@ -244,7 +244,9 @@ class TaskGroup extends EventEmitter
@setConfig(opts)
# Give setConfig enough chance to fire
- setImmediate(@fire.bind(@))
+ # Changing this to setImmediate breaks a lot of things
+ # As tasks inside nested taskgroups will fire in any order
+ process.nextTick(@fire.bind(@))
# Handle item completion
@on('item.complete', @itemCompletionCallback.bind(@))
Please sign in to comment.
Something went wrong with that request. Please try again.