From eed6843e8499c7e2463c797c9341f6794d1b6cca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Wed, 27 Jul 2022 16:51:03 +0000 Subject: [PATCH] remove disable-weak-memory-emulation (#5469) # Objective - Fixes #5164 - Remove `miri-disable-weak-memory-emulation` - Issue has been fixed in dependency --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cf73dd858aaca..624e3215057ec 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -93,9 +93,8 @@ jobs: # https://github.com/rust-lang/miri#miri--z-flags-and-environment-variables # -Zmiri-disable-isolation is needed because our executor uses `fastrand` which accesses system time. # -Zmiri-permissive-provenance disables warnings against int2ptr casts (since those are used by once_cell) - # -Zmiri-disable-weak-memory-emulation works around https://github.com/bevyengine/bevy/issues/5164. # -Zmiri-ignore-leaks is necessary because a bunch of tests don't join all threads before finishing. - MIRIFLAGS: -Zmiri-ignore-leaks -Zmiri-disable-isolation -Zmiri-permissive-provenance -Zmiri-disable-weak-memory-emulation + MIRIFLAGS: -Zmiri-ignore-leaks -Zmiri-disable-isolation -Zmiri-permissive-provenance check-compiles: runs-on: ubuntu-latest