Meshing for Annulus primitive
#12734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Feature
Jondolf
reviewed
Mar 26, 2024
Contributor
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
Jondolf
approved these changes
Mar 26, 2024
Contributor
Jondolf
left a comment
Jondolf
left a comment
There was a problem hiding this comment.
CI is screaming but it seems to be for unrelated reasons (as usual). LGTM!
I agree it'd be nice to add radial/polar UV mapping as a configuration option for Circle and Ellipse (and RegularPolygon?) in a follow-up.
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
# Objective - Depends on #12734. Since adding the `Annulus` primitive shape (#12706, #12734), the `2d_shapes` example has become outdated. ## Solution This PR adds the annulus shape to the `2d_shapes` example:  --- ## Changelog ### Added - `Annulus` shape to the `2d_shapes` example (~~as an added bonus, the example now features Newton's [ROYGBIV](https://en.wikipedia.org/wiki/ROYGBIV) rainbow palette ^^~~ no it doesn't, but one can shoehorn..)
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective Related to bevyengine#10572 Allow the `Annulus` primitive to be meshed. ## Solution We introduce a `Meshable` structure, `AnnulusMeshBuilder`, which allows the `Annulus` primitive to be meshed, leaving optional configuration of the number of angular sudivisions to the user. Here is a picture of the annulus's UV-mapping: <img width="1440" alt="Screenshot 2024-03-26 at 10 39 48 AM" src="https://github.com/bevyengine/bevy/assets/2975848/b170291d-cba7-441b-90ee-2ad6841eaedb"> Other features are essentially identical to the implementations for `Circle`/`Ellipse`. --- ## Changelog - Introduced `AnnulusMeshBuilder` - Implemented `Meshable` for `Annulus` with `Output = AnnulusMeshBuilder` - Implemented `From<Annulus>` and `From<AnnulusMeshBuilder>` for `Mesh` - Added `impl_reflect!` declaration for `Annulus` and `Triangle3d` in `bevy_reflect` --- ## Discussion ### Design considerations The only interesting wrinkle here is that the existing UV-mapping of `Ellipse` (and hence of `Circle` and `RegularPolygon`) is non-radial (it's skew-free, created by situating the mesh in a bounding rectangle), so the UV-mapping of `Annulus` doesn't limit to that of `Circle` as its inner radius tends to zero, for instance. I don't see this as a real issue for `Annulus`, which should almost certainly have this kind of UV-mapping, but I think we ought to at least consider allowing mesh configuration for `Circle`/`Ellipse` that performs radial UV-mapping instead. (In these cases in particular, it would be especially easy, since we wouldn't need a different parameter set in the builder.) --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective - Depends on bevyengine#12734. Since adding the `Annulus` primitive shape (bevyengine#12706, bevyengine#12734), the `2d_shapes` example has become outdated. ## Solution This PR adds the annulus shape to the `2d_shapes` example:  --- ## Changelog ### Added - `Annulus` shape to the `2d_shapes` example (~~as an added bonus, the example now features Newton's [ROYGBIV](https://en.wikipedia.org/wiki/ROYGBIV) rainbow palette ^^~~ no it doesn't, but one can shoehorn..)
alice-i-cecile
removed
the
M-Release-Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Related to #10572
Allow the
Annulusprimitive to be meshed.Solution
We introduce a
Meshablestructure,AnnulusMeshBuilder, which allows theAnnulusprimitive to be meshed, leaving optional configuration of the number of angular sudivisions to the user. Here is a picture of the annulus's UV-mapping:Other features are essentially identical to the implementations for
Circle/Ellipse.Changelog
AnnulusMeshBuilderMeshableforAnnuluswithOutput = AnnulusMeshBuilderFrom<Annulus>andFrom<AnnulusMeshBuilder>forMeshimpl_reflect!declaration forAnnulusandTriangle3dinbevy_reflectDiscussion
Design considerations
The only interesting wrinkle here is that the existing UV-mapping of
Ellipse(and hence ofCircleandRegularPolygon) is non-radial (it's skew-free, created by situating the mesh in a bounding rectangle), so the UV-mapping ofAnnulusdoesn't limit to that ofCircleas its inner radius tends to zero, for instance. I don't see this as a real issue forAnnulus, which should almost certainly have this kind of UV-mapping, but I think we ought to at least consider allowing mesh configuration forCircle/Ellipsethat performs radial UV-mapping instead. (In these cases in particular, it would be especially easy, since we wouldn't need a different parameter set in the builder.)