-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Moves intern and label modules into bevy_ecs #12772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves intern and label modules into bevy_ecs #12772
Conversation
james7132
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind fixing CI? The lints seem like they should be fixable by using cast::<()> instead of as.
3aea575 to
c67e12a
Compare
Done, rebased and updated the migration guide. Feel free to take a second look at it now @james7132. Thanks! |
5635dfb to
5a2ebf3
Compare
|
@james7132 I did a change that fixed the issue with |
| }, | ||
| }; | ||
|
|
||
| define_label!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need to make this [`Schedule`](crate::schedule::Schedule).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in the latest change @james7132
5a2ebf3 to
6b030bc
Compare
|
@james7132 something failed during the merge queuing process (and I see no logs on the step that failed... Maybe it was just a blip in the matrix during artifact upload?). I've updated the branch, if you could queue this one again I'll appreciate it. |
Objective
Solution
internmodule frombevy_utilsintobevy_ecscrate and updated all relevant imports.labelmodule frombevy_utilsintobevy_ecscrate and updated all relevant imports.Migration Guide
bevy_utils::define_labelimports withbevy_ecs::define_labelimports.bevy_utils::label::DynEqimports withbevy_ecs::label::DynEqimports.bevy_utils::label::DynHashimports withbevy_ecs::label::DynHashimports.bevy_utils::intern::Internedimports withbevy_ecs::intern::Internedimports.bevy_utils::intern::Internableimports withbevy_ecs::intern::Internableimports.bevy_utils::intern::Internerimports withbevy_ecs::intern::Internerimports.