Move close_on_esc to bevy_dev_tools
#12855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
close_on_escsystem is forcingbevy_windowto depend onbevy_input.close_on_escis not likely to be used in production, so it arguably does not have a place inbevy_window.Solution
close_on_escintobevy_dev_tools.bevy_window's dependency onbevy_input.bevy_reflect'ssmol_strfeature tobevy_windowbecause it was implicitly depended upon withbevy_inputbefore it was removed.close_on_escfrom the examples.bevy_dev_toolsis not enabled by default. I personally find it frustrating to run examples with additional features, so I opted to remove it entirely.Changelog
bevy_window::close_on_esctobevy_dev_tools::close_on_esc.bevy_dev_tools::close_on_escfrom all examples.Migration Guide
bevy_window::close_on_eschas been moved tobevy_dev_tools::close_on_esc. You will first need to enablebevy_dev_toolsas a feature in yourCargo.toml:Finally, modify any imports to use
bevy_dev_toolsinstead: