Add query reborrowing#14690
Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom Aug 15, 2024
Merged
Conversation
re0312
approved these changes
Aug 10, 2024
Contributor
re0312
left a comment
There was a problem hiding this comment.
I really like this . and from a performance perspective, except for some specific fetch , it's almost zero cost.
I did a simple bench and it was nearly 2X faster than our QueryCombinationIter<2>
chescock
approved these changes
Aug 11, 2024
ItsDoot
approved these changes
Aug 14, 2024
alice-i-cecile
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Query, but we don't want to give up ours;slice::split_first/slice::split_first_mutfor query iteratorsSolution
&'a mut Query<'w, 's, D, F>to aQuery<'a, 's, D, F>:&'short mut &'long mut Tto&'short mut Tthe the compiler automatically implements.WorldQuery.Showcase
Query, getting an equivalentQuerywith a shorter lifetime. Previously this was possible for read-only queries by usingQuery::to_readonly, now it's possible for mutable queries too;QueryIter.Migration Guide
WorldQuerynow has an additionalshrink_fetchmethod you have to implement if you were implementingWorldQuerymanually.