Add register_system_cached to DeferredWorld. #21972
Open
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhohenheim
approved these changes
Nov 29, 2025
| /// If you want to access values from the environment within a system, consider passing them in | ||
| /// as inputs via [`Commands::run_system_cached_with`]. If that's not an option, consider | ||
| /// [`Commands::register_system`] instead. | ||
| pub fn register_system_cached<I, O, M, S>(&mut self, system: S) -> SystemId<I, O> |
Member
There was a problem hiding this comment.
Maybe get_or_insert_system would be more idiomatic?
Contributor
Author
There was a problem hiding this comment.
World already has register_system_cached, and so I named this function likewise.
janhohenheim
added
A-ECS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow registering systems when uncached, while inside
on_addand its ilk.Solution
Add
register_system_cachedtoDeferredWorld.Testing
I tried it in an
on_addand it seemed to work just fine. The first time the component was spawned, it took the uncached branch and registered the system. The second time the component was spawned, it took the cached branch and retrieved the cachedSystemId.Minor Flaw
If this function is called twice for the same system before commands are executed, then it will register the system twice.
If you wish me to, then I can make it send out a warning when this occurs.